Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Fix facet distribution error #255

Merged
merged 3 commits into from
Jun 23, 2021
Merged

Fix facet distribution error #255

merged 3 commits into from
Jun 23, 2021

Conversation

Kerollmops
Copy link
Member

@Kerollmops Kerollmops commented Jun 23, 2021 •
edited
Loading

This PR fixes two invalid behaviors and fixes #253:

  • We were ignoring the list of fields for which the user wanted a facet distribution.
  • We were not raising any error for when a non-filterable field was requested a facet distribution.

For the latter behavior I need the help of @curquiza to help me choose the right error type.

@curquiza curquiza changed the title Fix facet distribution Fix facet distribution error Jun 23, 2021
@curquiza curquiza mentioned this pull request Jun 23, 2021
Closed
@Kerollmops Kerollmops requested a review from curquiza June 23, 2021 11:56
curquiza
curquiza approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@Kerollmops
Copy link
Member Author

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 23, 2021

Build succeeded:

@bors bors bot merged commit 66f55e3 into main Jun 23, 2021
@bors bors bot deleted the fix-facet-distribution branch June 23, 2021 12:29
@curquiza curquiza added the DB breaking The related changes break the DB label Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@curquiza curquiza curquiza approved these changes

Assignees
No one assigned
Labels
DB breaking The related changes break the DB
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should raise error when trying facetsDistribution on a non-filterable attribute
2 participants
@Kerollmops @curquiza